Remove old reference to inst._wrapperState#12987
Merged
gaearon merged 1 commit intofacebook:masterfrom Jun 11, 2018
Merged
Conversation
This commit removes a reference to inst._wrapperState, which was the old way of tracking input state in the stack renderer. This means we no longer need to pass the instance into the associated function, allowing us to eliminate an exception for IE (and a TODO).
80d36cf to
c578fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puddling along trying to figure out what to do for #12505, I noticed that we can remove an old reference to
inst._wrapperStatefor the stack renderer.This also means that we can remove the instance guard for IE in the associated function, checking off a TODO.