Skip to content

Conversation

@justinj
Copy link

@justinj justinj commented Mar 22, 2014

This caused issues when there would be a union of a shape checker which
did not pass, and another type which did. The shape checker would output
warnings even though the other type passed.

Also, I signed the CLA.

@sophiebits
Copy link
Collaborator

Looks good to me, thanks.

@chenglou
Copy link
Contributor

chenglou commented Apr 7, 2014

I've fixed this internally and added your test. The PropTypes are rewritten and no weak is needed anymore.
Will wait for @zpao to sync out, along with your tests.

@chenglou
Copy link
Contributor

@justinj can you rebase this? We've changed PropType a bit. .weak is no longer needed, but the tests are good.

@justinj
Copy link
Author

justinj commented Apr 10, 2014

Ok, thanks for fixing that problem :) I rebased the tests.

@sophiebits sophiebits changed the title Have PropTypes.shape use weak checks if it's weak Add PropTypes.shape tests Apr 10, 2014
@sophiebits sophiebits changed the title Add PropTypes.shape tests Add tests for oneOfType with shape Apr 10, 2014
zpao added a commit that referenced this pull request Apr 11, 2014
Add tests for oneOfType with shape
@zpao zpao merged commit cb2e394 into facebook:master Apr 11, 2014
@zpao
Copy link
Member

zpao commented Apr 11, 2014

Thanks @justinj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants