Replace inputValueTracking-test with public API tests#11654
Merged
gaearon merged 1 commit intofacebook:masterfrom Nov 25, 2017
Merged
Replace inputValueTracking-test with public API tests#11654gaearon merged 1 commit intofacebook:masterfrom
gaearon merged 1 commit intofacebook:masterfrom
Conversation
nhunzaker
approved these changes
Nov 25, 2017
Contributor
nhunzaker
left a comment
There was a problem hiding this comment.
I really like how clear this is, 👍
HeroProtagonist
pushed a commit
to HeroProtagonist/react
that referenced
this pull request
Nov 26, 2017
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #11333.
Now that I understand what input tracking is doing, I rewrote the remaining tests to follow the existing format and check the observable desired behavior, and rolled them into
ChangeEventPlugin-test.js.