Don't call componentDidUpdate() in shallow renderer#10372
Merged
gaearon merged 3 commits intofacebook:masterfrom Aug 3, 2017
Merged
Don't call componentDidUpdate() in shallow renderer#10372gaearon merged 3 commits intofacebook:masterfrom
gaearon merged 3 commits intofacebook:masterfrom
Conversation
sophiebits
approved these changes
Aug 3, 2017
Collaborator
sophiebits
left a comment
There was a problem hiding this comment.
I think this is good
bvaughn
approved these changes
Aug 3, 2017
Contributor
bvaughn
left a comment
There was a problem hiding this comment.
I'm okay with this change. Seems safer.
| typeof this._instance.componentDidUpdate === 'function' | ||
| ) { | ||
| this._instance.componentDidUpdate(oldProps, oldState); | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: Might be nice to leave a placeholder comment referencing why we decided not to call cDU
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did this for initial compatibility with Stack, but this behavior seems undesirable because it's inconsistent with
componentDidMount.Past discussion in #9426 (comment) seems to uncover Enzyme depends on it. Can we verify this is the case? I ran Jest internally and did not see issues caused by this change. Since Enzyme needs to adapt to other 16 changes, we might as well make this one.