Don't increase priority when cloning current children#10123
Merged
acdlite merged 1 commit intofacebook:masterfrom Jul 7, 2017
Merged
Don't increase priority when cloning current children#10123acdlite merged 1 commit intofacebook:masterfrom
acdlite merged 1 commit intofacebook:masterfrom
Conversation
This fixes a snapshot test regression introduced by facebook#10008. I had noticed this change and believe the new behavior was correct, but upon further investigation I was wrong. This reverts the snapshot test and fixes it accordingly.
Collaborator
|
Does it make sense to add an explicit test for this? |
Collaborator
Author
|
@spicyj Yes, though I can't think of a good one that isn't coupled to implementation. Ideally we'd cover this with a generative test suite, like with the triangle tester. |
Collaborator
|
Is this the selection.extend bug that surfaced in the sync? I thought it was but now maybe it's not. :) If it is then we could reduce that maybe? (If not, is there a fix for that somewhere?) |
Collaborator
Author
|
It's a separate bug that happened to manifest as triggering the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a snapshot test regression introduced by #10008. I had noticed this change and believed the new behavior was correct, but upon further investigation I was wrong. This reverts the snapshot test and fixes it accordingly.