add settings to android webview to allow enabling file scheme and thi…#9949
add settings to android webview to allow enabling file scheme and thi…#9949thurber wants to merge 1 commit intofacebook:masterfrom thurber:android-webview-settings-to-accept-file-and-third-party-cookies
Conversation
|
By analyzing the blame information on this pull request, we identified @spicyj and @caabernathy to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @jacobp100 as a potential reviewer. Could you take a look please or cc someone with more context? |
|
What issue is this solving? Can you add tests? |
|
I had needed this to be able to view pdfs via an implementation of Mozilla's pdfjs embedded as a file url, when the pdfs required a previously obtained session cookie to access. I've since implemented a workaround, so happy to close out this PR if no one else needs it. |
|
There's another PR (#10946) that lets you add behaviour to the existing web view. I think this is quite specific, so I think we should wait and see what happens with said PR. |
|
I think we have too many possible configurable behavior things to add every prop to WebView, so if the approach in 10946 works that is ideal. Let's close this pull request but we can reopen if more general approaches fail. |
Add two props to android WebView: