Get RCTPushNotificationManager compiling for AppleTV#55214
Closed
sbuggay wants to merge 5 commits intofacebook:mainfrom
Closed
Get RCTPushNotificationManager compiling for AppleTV#55214sbuggay wants to merge 5 commits intofacebook:mainfrom
sbuggay wants to merge 5 commits intofacebook:mainfrom
Conversation
Summary: SurfaceTouch and SurfacePointer handlers use a lot of unsupported UIKit APIs. Instead of granuarly wrapping the UIKit usage, this minimally removes the handlers from AppleTV all-together, as they no-op anyways (there is no click-through support on simulator.) Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D90704270
Summary: Platform guarding some unavailable UIKit APIs. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D90711498
Summary: UISwitch, UIRefreshControl, UIKeyboardNotifications ,and UIPasteBoard are unavailable on AppleTV https://developer.apple.com/documentation/uikit/uiswitch?language=objc https://developer.apple.com/documentation/uikit/uirefreshcontrol?language=objc https://developer.apple.com/documentation/uikit/uiresponder/keyboardwillshownotification?language=objc https://developer.apple.com/documentation/uikit/uipasteboard?language=objc Changelog: [Internal] Reviewed By: javache Differential Revision: D90712066
Summary: A few places `available` is missing tvOS, adding to fix the build. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D90712192
Summary: Some various `removeDeliveredNotifications` APIs aren't supported on AppleTV, no-oping. https://developer.apple.com/documentation/usernotifications/unusernotificationcenter/removedeliverednotifications(withidentifiers:)?language=objc Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D90825526
Contributor
Author
|
cc: @douglowder |
|
This pull request has been merged in 7b0dbc1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some various
removeDeliveredNotificationsAPIs aren't supported on AppleTV, no-oping.https://developer.apple.com/documentation/usernotifications/unusernotificationcenter/removedeliverednotifications(withidentifiers:)?language=objc
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D90825526