RN: Remove Special Case for "Warning: " Errors#55193
Closed
yungsters wants to merge 1 commit intofacebook:mainfrom
Closed
RN: Remove Special Case for "Warning: " Errors#55193yungsters wants to merge 1 commit intofacebook:mainfrom
yungsters wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary:
React no longer emits the "Warning: " prefix from error messages, so we no longer need special handling for error messages with this prefix.
If third party call sites are depending on `console.error('Warning: …')` being treated as a warning, they should be migrated to use `console.warn('…')`.
Changelog:
[General][Changed] - Logs created by `console.error` that begin with "Warning: " will no longer be treated as warnings. These call sites should migrate to using `console.warn` instead.
Differential Revision: D90795590
|
@yungsters has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90795590. |
Collaborator
|
This pull request was successfully merged by @yungsters in 5ab4184 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
React no longer emits the "Warning: " prefix from error messages, so we no longer need special handling for error messages with this prefix.
If third party call sites are depending on
console.error('Warning: …')being treated as a warning, they should be migrated to useconsole.warn('…').Changelog:
[General][Changed] - Logs created by
console.errorthat begin with "Warning: " will no longer be treated as warnings. These call sites should migrate to usingconsole.warninstead.Differential Revision: D90795590