Prevent view collapsing when pointerEvents is 'box-only'#55185
Closed
fabriziocucci wants to merge 2 commits intofacebook:mainfrom
Closed
Prevent view collapsing when pointerEvents is 'box-only'#55185fabriziocucci wants to merge 2 commits intofacebook:mainfrom
fabriziocucci wants to merge 2 commits intofacebook:mainfrom
Conversation
…ckage Summary: This change makes `ImportantForInteractionHelper` internal to avoid exposing it as part of the public API. The class is moved from `com.facebook.react.uimanager` to `com.facebook.react.views.view` package since it's only used by `ReactViewGroup` and `ReactViewManager` within that package. This reduces the public API surface of ReactAndroid and keeps implementation details private. Differential Revision: D90767295
Summary: Changelog: [Internal] This change ensures that views with `pointerEvents` set to `'box-only'` are not collapsed, preserving the parent-children relationship in the view hierarchy. This is necessary because when `importantForInteraction` is applied on a view with `pointerEvents='box-only'`, the view must remain in the hierarchy to correctly signal to its children that they are not important for interaction. Without this fix, the view could be collapsed during flattening, breaking the propagation of the `importantForInteraction` property to descendant views. Differential Revision: D90772188
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90772188. |
|
This pull request has been merged in 0649717. |
Collaborator
|
This pull request was successfully merged by @fabriziocucci in 0649717 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This change ensures that views with
pointerEventsset to'box-only'are not collapsed, preserving the parent-children relationship in the view hierarchy.This is necessary because when
importantForInteractionis applied on a view withpointerEvents='box-only', the view must remain in the hierarchy to correctly signal to its children that they are not important for interaction. Without this fix, the view could be collapsed during flattening, breaking the propagation of theimportantForInteractionproperty to descendant views.Differential Revision: D90772188