Move state of PackagerConnectionSettings to companion object#54852
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Move state of PackagerConnectionSettings to companion object#54852cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: While working on internal apps, I've noticed that there are scenarios where more than one `PackagerConnectionSettings` is instantiated. What that happens, we're not able to reliability change the host anymore, because the state is scattered through the various `PackagerConnectionSettings`. Instead the state should be retained as a singleton. Differential Revision: D88945232
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88945232. |
Collaborator
|
This pull request was successfully merged by @cortinico in 28d6ba1 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 28d6ba1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on internal apps, I've noticed that there are scenarios where more than one
PackagerConnectionSettingsis instantiated.What that happens, we're not able to reliability change the host anymore, because the state is scattered through the various
PackagerConnectionSettings. Instead the state should be retained as a singleton.Differential Revision: D88945232