Skip to content

fix: RNGP CCache compatibility#54829

Closed
tjzel wants to merge 3 commits intofacebook:mainfrom
tjzel:@tjzel/rngp-ccache
Closed

fix: RNGP CCache compatibility#54829
tjzel wants to merge 3 commits intofacebook:mainfrom
tjzel:@tjzel/rngp-ccache

Conversation

@tjzel
Copy link
Copy Markdown
Contributor

@tjzel tjzel commented Dec 9, 2025

Summary:

Invoking Runtime.getRuntime().exec() is not compatible with Gradle Configuration Cache and providers should be used instead.

This error hasn't surfaced yet due to fact that this branch of code is rarely hit as the users usually provide correct path to the CLI in their app/build.gradle file. I stumbled upon it accidentally when bumping RN in monorepo and the CLI path was no longer valid.

Re-opened due to failing tests in the previous PR #54801

Changelog:

[ANDROID] [FIXED] - RNGP using node invocation non-compatible with Gradle Compilation Cache

Test Plan:

I tested it in a rnc-cli app, where I provided an invalid path for cliFile - the error was fixed after applying this patch.

./gradlew -p packages/gradle-plugin/ test now works properly.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2025
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner labels Dec 9, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 9, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 9, 2025

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D88757054.

@meta-codesync meta-codesync bot closed this in dd1f83e Dec 10, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 10, 2025

@cortinico merged this pull request in dd1f83e.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 10, 2025
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @tjzel in dd1f83e

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants