Fix build issues when RCT_REMOVE_LEGACY_ARCH is turned on internally#54821
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Fix build issues when RCT_REMOVE_LEGACY_ARCH is turned on internally#54821cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: This diff addresses build issues that arise when the `RCT_REMOVE_LEGACY_ARCH` flag is enabled internally. The changes ensure that the build process is compatible with the updated architecture. ## Changelog: [Internal] - Make sure that we can build using BUCK when the RCT_NEW_ARCH_ENABLED flag is turned on. Differential Revision: D88651074
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88651074. |
|
This pull request has been merged in 41c50fd. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 41c50fd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff addresses build issues that arise when the
RCT_REMOVE_LEGACY_ARCHflag is enabled internally. The changes ensure that the build process is compatible with the updated architecture.Changelog:
[Internal] - Make sure that we can build using BUCK when the RCT_NEW_ARCH_ENABLED flag is turned on.
Differential Revision: D88651074