fix hit test for components using legacy module interop #54802
fix hit test for components using legacy module interop #54802kruczy wants to merge 1 commit intofacebook:mainfrom
Conversation
e933057 to
ebe2cb4
Compare
|
@kruczy Can you add how this was verified or tested? |
|
hi, sure @alanleedev We have a legacy floating panel component that we wrote very long time ago (its on its way out but still used in a few places) when we migrated to new arch we had the issue that when the FP is not fully open anything behind it would not be pressable in new arch only and its because of the hitTest missing here, with this change the behavior returned to correct one. just to explain the code further this just does same as it would by default except ensuring the wrapper is not hit by gestures (since it will never have any gesture behavior anyway) allowing other components to take the gesture |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D88630976. |
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in 700d320. |
|
This pull request was successfully merged by @kruczy in 700d320 When will my fix make it into a release? | How to file a pick request? |
Summary:
This fixes hit tests in view using legacy module interop since the interop adds another view surrounding the actual view it needs to delegate the hit test to the actual component it wraps
Changelog:
[IOS] [FIXED] - Fix legacy module interop not handling hitTest correctly
Test Plan: