Add listener API to OverrideColorScheme for dynamic dark mode updates#54791
Closed
alanleedev wants to merge 1 commit intofacebook:mainfrom
Closed
Add listener API to OverrideColorScheme for dynamic dark mode updates#54791alanleedev wants to merge 1 commit intofacebook:mainfrom
alanleedev wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88427482. |
b51bc8f to
4978134
Compare
4978134 to
d14b565
Compare
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Dec 5, 2025
…facebook#54791) Summary: This change adds a listener mechanism to the `OverrideColorScheme` interface to enable dynamic updates when the user's dark mode preference changes via `OverrideColorScheme`. Previously, `AppearanceModule` would only reflect the initial color scheme state when instantiated. If a user toggled dark mode through an `OverrideColorScheme` implementation, React Native JavaScript would not be notified of the change, causing UI inconsistencies. This implementation adds: 1. An optional `addSchemeChangeListener()` method to the `OverrideColorScheme` interface with a default no-op implementation for backward compatibility. Also adding matching `removeSchemeChangeListener()`. 2. Automatic listener registration in `AppearanceModule`'s init block that triggers `onConfigurationChanged()` when the color scheme changes Changelog: [Android][Added] - Add `addSchemeChangeListener()` function to `OverrideColorScheme` interface to support dynamic appearance updates via override Reviewed By: javache Differential Revision: D88427482
d14b565 to
d99d259
Compare
…facebook#54791) Summary: This change adds a listener mechanism to the `OverrideColorScheme` interface to enable dynamic updates when the user's dark mode preference changes via `OverrideColorScheme`. Previously, `AppearanceModule` would only reflect the initial color scheme state when instantiated. If a user toggled dark mode through an `OverrideColorScheme` implementation, React Native JavaScript would not be notified of the change, causing UI inconsistencies. This implementation adds: 1. An optional `addSchemeChangeListener()` method to the `OverrideColorScheme` interface with a default no-op implementation for backward compatibility. Also adding matching `removeSchemeChangeListener()`. 2. Automatic listener registration in `AppearanceModule`'s init block that triggers `onConfigurationChanged()` when the color scheme changes Changelog: [Android][Added] - Add `addSchemeChangeListener()` function to `OverrideColorScheme` interface to support dynamic appearance updates via override Reviewed By: javache Differential Revision: D88427482
d99d259 to
c8d9200
Compare
|
This pull request has been merged in 80e384a. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 80e384a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a listener mechanism to the
OverrideColorSchemeinterface to enable dynamic updates when the user's dark mode preference changes viaOverrideColorScheme.Previously,
AppearanceModulewould only reflect the initial color scheme state when instantiated. If a user toggled dark mode through anOverrideColorSchemeimplementation, React Native JavaScript would not be notified of the change, causing UI inconsistencies.This implementation adds:
addListener()method to theOverrideColorSchemeinterface with a default no-op implementation for backward compatibilityAppearanceModule's init block that triggersonConfigurationChanged()when the color scheme changesChangelog:
[Android][Added] - Add
addListener()function toOverrideColorSchemeinterface to support dynamic appearance updates via overrideDifferential Revision: D88427482