move default React Native DevTools launching params downstream#54528
Closed
vzaidman wants to merge 3 commits intofacebook:mainfrom
Closed
move default React Native DevTools launching params downstream#54528vzaidman wants to merge 3 commits intofacebook:mainfrom
vzaidman wants to merge 3 commits intofacebook:mainfrom
Conversation
825739f to
121fded
Compare
db616e4 to
692553c
Compare
692553c to
e6ff429
Compare
ed7c9b1 to
107f7fc
Compare
107f7fc to
a096fc2
Compare
c153ab9 to
994e8e1
Compare
994e8e1 to
3d1e790
Compare
3d1e790 to
96f5d4a
Compare
96f5d4a to
45b02d4
Compare
45b02d4 to
351a658
Compare
351a658 to
93d1dc4
Compare
…g event on if this changes (facebook#54447) Summary: Changelog: [Internal] Expose `unstable_hasConnectedDevices` and `unstable_addHasConnectedDevicesListener` from both `InspectorProxy` and `DevMiddleware` that tells the user if any devices are connected to `devMiddleware` and allows to listen to whenever this state changes. Reviewed By: motiz88 Differential Revision: D86319965
…ODE (facebook#54654) Summary: make the default debugger-shell spawn command unset ELECTRON_RUN_AS_NODE Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D86673603
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Reviewed By: motiz88 Differential Revision: D86772692
93d1dc4 to
175262d
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Dec 9, 2025
…ook#54528) Summary: Changelog: [Internal] Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults. Reviewed By: motiz88 Differential Revision: D86772692
|
This pull request has been merged in 1c282d7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently,
DefaultBrowserLauncher.jsholds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and makeDefaultBrowserLauncher.jsuse the defaults.Differential Revision: D86772692