Skip to content

fix(test): fix RNTester iOS unit and integration tests#53848

Closed
artus9033 wants to merge 63 commits intofacebook:mainfrom
artus9033:fix/rntester-tests
Closed

fix(test): fix RNTester iOS unit and integration tests#53848
artus9033 wants to merge 63 commits intofacebook:mainfrom
artus9033:fix/rntester-tests

Conversation

@artus9033
Copy link
Copy Markdown
Contributor

@artus9033 artus9033 commented Sep 18, 2025

Summary:

This PR fixes problems with unit & integration tests in the iOS RNTester project, related to: compilation errors, JS problems, missing mocks & outdated baselines.

Changelog:

[GENERAL] [FIXED] - IntegrationTestsApp not registering components under proper names, breaking integration tests
[GENERAL] [FIXED] - IntegrationTestsApp flow types
[GENERAL] [FIXED] - Re-enabled iOS unit & integration tests, Ruby tests on CI, stripped obsolete build part before running tests, renamed uploaded xcresult artifacts
[GENERAL] [FIXED] - Fixed test_ios_rntester_dynamic_frameworks to respect the matrix flavor value, disabled running tests from that task to prevent artifact name conflicts since the test results for dynamic frameworks are uploaded from test_ios_rntester
[IOS] [FIXED] - Fixed Ruby scripting tests, refactored order of arguments to assert_equals where it was swapped
[IOS] [FIXED] - Reconfigured CI iOS test runner to run on iPhone 16, iOS 18.1, since the previous device was missing in the runner setup
[IOS] [FIXED] - Compilation errors of iOS unit tests
[IOS] [FIXED] - Fixed logic of broken iOS tests, add missing mocks
[IOS] [FIXED] - Disabled / skipped unit & integration tests that are coupled with legacy architecture bridge, which now throws upon initialization
[GENERAL] [FIXED] - Undefined symbols when building for testing due to missing CPP file in RCT-Folly.podspec

Test Plan:

  1. iOS tests pass:
  • When run from dedicated xcschemes:
image image
  • When run from the RNTester scheme (command + U):
image
  1. Ruby scripting tests pass:
image
  1. CI - green
  2. xcresult artifacts are uploaded
image

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2025
@artus9033 artus9033 changed the title fix(test): fix RNTester iOS unit and instrumentation tests fix(test): fix RNTester iOS unit and integration tests Sep 21, 2025
@artus9033 artus9033 marked this pull request as ready for review September 21, 2025 10:39
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 21, 2025
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, I left a couple of comments.

We also have in CI a flag here and here that leverage these tests.

It would be nice if we can enable them to run in CI so we can keep them checked while we develop react native.

Can you update the PR with that?

@artus9033
Copy link
Copy Markdown
Contributor Author

Absolutely, thanks for the comments, I'll address them today.

Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Unfortunately, there are a couple of issues that needs to be addressed!

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 9, 2025

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D88733170.

@meta-codesync meta-codesync bot closed this in 2ce3686 Dec 10, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 10, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 10, 2025

@cipolleschi merged this pull request in 2ce3686.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @artus9033 in 2ce3686

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants