fix(test): fix RNTester iOS unit and integration tests#53848
Closed
artus9033 wants to merge 63 commits intofacebook:mainfrom
Closed
fix(test): fix RNTester iOS unit and integration tests#53848artus9033 wants to merge 63 commits intofacebook:mainfrom
artus9033 wants to merge 63 commits intofacebook:mainfrom
Conversation
…ifecycle-originating updates from DeviceEventEmitter
…s, do not attach debugger to tests by default
9e9630c to
c9484f1
Compare
cipolleschi
requested changes
Sep 22, 2025
Contributor
Author
|
Absolutely, thanks for the comments, I'll address them today. |
… the default export in IntegrationTestsApp
…nUtils.set_react_codegen_podspec_generated
541db2a to
595c9a8
Compare
9fde1ec to
e1a3d5e
Compare
3f1af5f to
d417c0f
Compare
cipolleschi
requested changes
Dec 9, 2025
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Great job! Unfortunately, there are a couple of issues that needs to be addressed!
cipolleschi
approved these changes
Dec 9, 2025
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D88733170. |
|
@cipolleschi merged this pull request in 2ce3686. |
Collaborator
|
This pull request was successfully merged by @artus9033 in 2ce3686 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes problems with unit & integration tests in the iOS RNTester project, related to: compilation errors, JS problems, missing mocks & outdated baselines.
Changelog:
[GENERAL] [FIXED] - IntegrationTestsApp not registering components under proper names, breaking integration tests
[GENERAL] [FIXED] - IntegrationTestsApp flow types
[GENERAL] [FIXED] - Re-enabled iOS unit & integration tests, Ruby tests on CI, stripped obsolete build part before running tests, renamed uploaded xcresult artifacts
[GENERAL] [FIXED] - Fixed
test_ios_rntester_dynamic_frameworksto respect the matrix flavor value, disabled running tests from that task to prevent artifact name conflicts since the test results for dynamic frameworks are uploaded fromtest_ios_rntester[IOS] [FIXED] - Fixed Ruby scripting tests, refactored order of arguments to
assert_equalswhere it was swapped[IOS] [FIXED] - Reconfigured CI iOS test runner to run on iPhone 16, iOS 18.1, since the previous device was missing in the runner setup
[IOS] [FIXED] - Compilation errors of iOS unit tests
[IOS] [FIXED] - Fixed logic of broken iOS tests, add missing mocks
[IOS] [FIXED] - Disabled / skipped unit & integration tests that are coupled with legacy architecture bridge, which now throws upon initialization
[GENERAL] [FIXED] - Undefined symbols when building for testing due to missing CPP file in
RCT-Folly.podspecTest Plan: