RuntimeExecutor: Refine the variables and comments again#51429

Closed

RSNara wants to merge 1 commit intofacebook:mainfrom

RSNara:export-D74941734

Contributor

RSNara commented May 17, 2025

Summary:
Just refactoring an renaming the variables inside RuntimeExecutor again (in a separate diff). Just so that the logic in the subsequent diffs is easier to read: D74769326

Changelog: [Internal]

Differential Revision: D74941734

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented May 17, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

facebook-github-bot added the fb-exported label

RSNara force-pushed the export-D74941734 branch from 7d437a7 to 3f15164 Compare

May 18, 2025 16:23

Contributor

facebook-github-bot commented May 18, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 3f15164 to e39a03a Compare

May 19, 2025 00:58

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from e39a03a to e197eee Compare

May 19, 2025 01:48

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from e197eee to 2ac9436 Compare

May 19, 2025 18:56

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 2ac9436 to 98c4338 Compare

May 20, 2025 20:35

Contributor

facebook-github-bot commented May 20, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 98c4338 to 7d7293f Compare

May 20, 2025 20:40

Contributor

facebook-github-bot commented May 20, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 7d7293f to ced90a9 Compare

May 20, 2025 20:45

RSNara force-pushed the export-D74941734 branch from ced90a9 to d164547 Compare

May 20, 2025 22:37

Contributor

facebook-github-bot commented May 20, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from d164547 to b55f6f7 Compare

May 20, 2025 22:41

RSNara force-pushed the export-D74941734 branch from b55f6f7 to 57d6846 Compare

May 21, 2025 01:02

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 57d6846 to 5e429f1 Compare

May 21, 2025 14:30

RSNara force-pushed the export-D74941734 branch from 787dc90 to 34745fc Compare

May 23, 2025 21:58

RSNara force-pushed the export-D74941734 branch from 34745fc to 9759f50 Compare

May 23, 2025 22:00

Contributor

facebook-github-bot commented May 23, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

1 similar comment

Contributor

facebook-github-bot commented May 23, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 9759f50 to 700609c Compare

May 23, 2025 22:02

RSNara force-pushed the export-D74941734 branch from 700609c to 798a58f Compare

May 24, 2025 03:22

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Use promises in sync ui thread utils (facebook#51429)

0334fdc

Summary:
Pull Request resolved: facebook#51429

If we use promises, I believe the code is just easier to understand.

Changelog: [Internal]

Differential Revision: D74941734

Contributor

facebook-github-bot commented May 24, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from 798a58f to d91564c Compare

May 24, 2025 03:26

RSNara force-pushed the export-D74941734 branch from d91564c to cade122 Compare

May 24, 2025 04:22

Contributor

facebook-github-bot commented May 24, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from cade122 to dee95c3 Compare

May 27, 2025 16:40


          RuntimeExecutor: Use promises in sync ui thread utils (facebook#51429)

52f7225

Summary:
Pull Request resolved: facebook#51429

If we use promises, I believe the code is just easier to understand.

Changelog: [Internal]

Reviewed By: javache, yungsters

Differential Revision: D74941734

Contributor

facebook-github-bot commented May 27, 2025

This pull request was exported from Phabricator. Differential Revision: D74941734

RSNara force-pushed the export-D74941734 branch from dee95c3 to 52f7225 Compare

May 27, 2025 16:44

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Use promises in sync ui thread utils (facebook#51429)

d0c328e

Summary:
Pull Request resolved: facebook#51429

If we use promises, I believe the code is just easier to understand.

Changelog: [Internal]

Differential Revision: D74941734

facebook-github-bot closed this in

Collaborator

react-native-bot commented May 27, 2025

This pull request was successfully merged by @RSNara in 4974839

^{When will my fix make it into a release? | How to file a pick request?}

react-native-bot added the Merged label

Contributor

facebook-github-bot commented May 27, 2025

This pull request has been merged in 4974839.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner