fix: return nullptr when USE_THIRD_PARTY_JSC is set to true#49781
Closed
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Closed
fix: return nullptr when USE_THIRD_PARTY_JSC is set to true#49781okwasniewski wants to merge 1 commit intofacebook:mainfrom
okwasniewski wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 515ff1e. |
Collaborator
|
This pull request was successfully merged by @okwasniewski in 515ff1e When will my fix make it into a release? | How to file a pick request? |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…#49781) Summary: When setting `USE_THIRD_PARTY_JSC=1`, we don't return anything from createJSRuntimeFactory function:  It's meant to be overwritten, but we must satisfy the compiler. ## Changelog: [IOS] [FIXED] - return nullptr when USE_THIRD_PARTY_JSC is set to true Pull Request resolved: facebook#49781 Test Plan: CI Green Reviewed By: cortinico Differential Revision: D70486837 Pulled By: cipolleschi fbshipit-source-id: c09622f75608dc203d41167fc375a000a2f12e37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When setting
USE_THIRD_PARTY_JSC=1, we don't return anything from createJSRuntimeFactory function:It's meant to be overwritten, but we must satisfy the compiler.
Changelog:
[IOS] [FIXED] - return nullptr when USE_THIRD_PARTY_JSC is set to true
Test Plan:
CI Green