[RNGP] pull out jsctooling when useThirdPartyJSC is true#49365
Closed
Kudo wants to merge 2 commits intofacebook:mainfrom
Closed
[RNGP] pull out jsctooling when useThirdPartyJSC is true#49365Kudo wants to merge 2 commits intofacebook:mainfrom
Kudo wants to merge 2 commits intofacebook:mainfrom
Conversation
cortinico
approved these changes
Feb 13, 2025
Contributor
cortinico
left a comment
There was a problem hiding this comment.
LGTM just a small nit for readability
.../react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/NdkConfiguratorUtils.kt
Outdated
Show resolved
Hide resolved
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 66032f2. |
Collaborator
|
This pull request was successfully merged by @Kudo in 66032f2 When will my fix make it into a release? | How to file a pick request? |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: an effort of lean core for jsc: https://github.com/Kudo/discussions-and-proposals/blob/%40kudo/lean-core-jsc/proposals/0836-lean-core-jsc.md ## Changelog: [ANDROID] [CHANGED] - exclude `jsctooling` when `useThirdPartyJSC` gradle property is true Pull Request resolved: facebook#49365 Test Plan: - ci passed - test from react-native-community/javascriptcore#4 Reviewed By: cipolleschi Differential Revision: D69654289 Pulled By: cortinico fbshipit-source-id: 148e07c7114dde05c2014522f9c56119f7f6f0ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
an effort of lean core for jsc: https://github.com/Kudo/discussions-and-proposals/blob/%40kudo/lean-core-jsc/proposals/0836-lean-core-jsc.md
Changelog:
[ANDROID] [CHANGED] - exclude
jsctoolingwhenuseThirdPartyJSCgradle property is trueTest Plan: