Expose mapbufferjni via prefab#44684
Closed
tomekzaw wants to merge 1 commit intofacebook:mainfrom
tomekzaw:@tomekzaw/expose-mapbufferjni
Closed
Expose mapbufferjni via prefab#44684tomekzaw wants to merge 1 commit intofacebook:mainfrom tomekzaw:@tomekzaw/expose-mapbufferjni
mapbufferjni via prefab#44684tomekzaw wants to merge 1 commit intofacebook:mainfrom
tomekzaw:@tomekzaw/expose-mapbufferjni
Conversation
Base commit: a908387 |
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request was successfully merged by @tomekzaw in c73e221. When will my fix make it into a release? | How to file a pick request? |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 7, 2024
Summary: After D57856389 (facebook#44684), the build is now firing an issue as `libmapbufferjni.so` is exposed as a public `.so` and we're missing a pickFirst directive. Changelog: [Internal] [Changed] - Add libmapbufferjni.so to pickFirst directives Differential Revision: D58284481
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: #44827 After D57856389 (#44684), the build is now firing an issue as `libmapbufferjni.so` is exposed as a public `.so` and we're missing a pickFirst directive. Changelog: [Internal] [Changed] - Add libmapbufferjni.so to pickFirst directives Reviewed By: javache Differential Revision: D58284481 fbshipit-source-id: d476bd5df8ec4687177df7a698cbb6595ce62565
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: The `mapbufferjni` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on facebook#36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `mapbufferjni` via prefab. Pull Request resolved: facebook#44684 Reviewed By: fabriziocucci Differential Revision: D57856389 Pulled By: javache fbshipit-source-id: 9926b02724950f4025c7f867257e8229d44c43a3
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44827 After D57856389 (facebook#44684), the build is now firing an issue as `libmapbufferjni.so` is exposed as a public `.so` and we're missing a pickFirst directive. Changelog: [Internal] [Changed] - Add libmapbufferjni.so to pickFirst directives Reviewed By: javache Differential Revision: D58284481 fbshipit-source-id: d476bd5df8ec4687177df7a698cbb6595ce62565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
mapbufferjniwas not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.Changelog:
[ANDROID] [CHANGED] - Expose
mapbufferjnivia prefab.Test Plan: