[RN][iOS] Fix static linking for Bridgeless mode#43846
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][iOS] Fix static linking for Bridgeless mode#43846cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
@gabrieldonadel I tested this locally and it works. Do you mind test it yourself as well? |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
gabrieldonadel
left a comment
There was a problem hiding this comment.
Hi @cipolleschi, amazing work! I just tested this on Expo's repo and it fixes the issues with importing #import <ReactCommon/RCTHost.h>, thanks!
I'm still facing some issues when importing #import <reacthermes/HermesExecutorFactory.h> but we can address that in another PR
Contributor
|
@cipolleschi merged this pull request in 0b6b8e2. |
|
This pull request was successfully merged by @cipolleschi in 0b6b8e2. When will my fix make it into a release? | How to file a pick request? |
cortinico
pushed a commit
that referenced
this pull request
Apr 8, 2024
Summary: Working with gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure. When a user tries to import `ReactCommon/RCTHost` in the app delegate, for example, the user ends up with an error and they can't find the files. These changes fixes this by establishing the right folder structure in the static frameworks ## Changelog: [Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks Pull Request resolved: #43846 Test Plan: Tested locally on an app with 0.74. Before: it failed to build. After: it build successfully. Reviewed By: cortinico Differential Revision: D55741581 Pulled By: cipolleschi fbshipit-source-id: 11ac0882d3feea05ef8904d55856ba5704b7a3b8
This was referenced Apr 9, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Working with @gabrieldonadel, we realized that static frameworks of the React-RendererRuntime are not following the proper folder structure.
When a user tries to import
ReactCommon/RCTHostin the app delegate, for example, the user ends up with an error and they can't find the files.These changes fixes this by establishing the right folder structure in the static frameworks
Changelog:
[Internal] - Make sure that React-RuntimeCore and JSErrorHandler are created with the proper structure for static frameworks
Test Plan:
Tested locally on an app with 0.74.
Before: it failed to build.
After: it build successfully.