[rn][ios][0.74][RC6] decouple RCTBridge+Private from jsinspector-modern#43708
Merged
huntie merged 1 commit intofacebook:0.74-stablefrom Apr 2, 2024
Merged
[rn][ios][0.74][RC6] decouple RCTBridge+Private from jsinspector-modern#43708huntie merged 1 commit intofacebook:0.74-stablefrom
huntie merged 1 commit intofacebook:0.74-stablefrom
Conversation
Base commit: f7ec469 |
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: [Internal]
Summary
new debugger logic added in 0.74 implicitly imported a C++ library depending on boost into the public headers for anyone importing RCTBridge+Private, which is a common header imported by libraries. boost is hard to link correctly, so this has caused issues with libraries such as OP-SQLite (#43204).
this must be picked directly against 0.74 instead of off master because PageTarget was renamed to HostTarget after the 0.74 cut.
do not pick into master!!!
Test Plan
build passes