Migrate back to chromium-edge-launcher since Windows fix was merged#43524
Closed
Migrate back to chromium-edge-launcher since Windows fix was merged#43524
Conversation
Collaborator
Author
|
cc @acoates-ms |
Contributor
|
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
approved these changes
Mar 18, 2024
Contributor
Contributor
|
This pull request has been reverted by ff5e1a6. |
Collaborator
Author
|
@motiz88 Any idea why this was backed out? |
Contributor
|
Yeah, there was an issue with our internal Flow config referencing the old libdef file name. I'll fix and reland. |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 19, 2024
Summary: A resubmission of D55013623 (Pull Request resolved: facebook#43524) with a fix for the internal `.flowconfig` issue that got the initial diff reverted. --- The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork. ## Changelog: [INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows Differential Revision: D55087731
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
…43562) Summary: Pull Request resolved: #43562 A resubmission of D55013623 (Pull Request resolved: #43524) with a fix for the internal `.flowconfig` issue that got the initial diff reverted. --- The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork. ## Changelog: [INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: NickGerleman Differential Revision: D55087731 fbshipit-source-id: 6fd28a32447ad07dacdf6cd77390e18489fd6cfb
kelset
pushed a commit
to microsoft/rnx-kit
that referenced
this pull request
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Windows fix was merged and published. We no longer need to use the fork.
Changelog:
[INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows
Test Plan:
n/a