use structs instead of class for TextInputMetrics and KeyPressMetrics#43510
Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Closed
use structs instead of class for TextInputMetrics and KeyPressMetrics#43510sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: changelog: [internal] - use designated initializers. - make TextInputMetrics and KeyPressMetrics structs. - move TextInputMetrics and KeyPressMetrics inside of TextInputEventEmitter. - Utilise RCTSizeFromCGSize, RCTEdgeInsetsFromUIEdgeInsets and RCTPointFromCGPoint when creating TextInputMetrics. Reviewed By: rshest Differential Revision: D54895928
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54895928 |
Base commit: fb42a55 |
Contributor
|
This pull request has been merged in 06dc448. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Reviewed By: rshest
Differential Revision: D54895928