[RN][iOS] Add checks on iOS 17 to compile out UIHoverStyle when not supported#43330
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][iOS] Add checks on iOS 17 to compile out UIHoverStyle when not supported#43330cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
2a71f3c to
0d62331
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Commit 73664f5 broke two jobs in CircleCI that we run using Xcode 14.3.1 because the commit introduced some types that are available only to iOS 17.
The code was wrapped around
if(@available())statement, but this does not compile out the code. It is a runtime check and the code needs to build anyway.source: https://forums.swift.org/t/if-vs-available-vs-if-available/40266/2
This change should fix it, introducing some compile time pragmas that removes the code if we build with older versions of Xcode
Changelog:
[iOS][Changed] - Compile out UIHoverStyle code for older Xcode versions
Test Plan:
CircleCI is green