Use host-relative WebSocket URLs when launching new debugger#43169
Closed
motiz88 wants to merge 2 commits intofacebook:mainfrom
Closed
Use host-relative WebSocket URLs when launching new debugger#43169motiz88 wants to merge 2 commits intofacebook:mainfrom
motiz88 wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54107316 |
Base commit: 12f2c3c |
Summary: Changelog: [Internal] Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@12a45e0...9ceb0ad ). Reviewed By: huntie Differential Revision: D54107317
Summary: Changelog: [Internal] Uses the capability introduced in facebook/react-native-devtools-frontend#4 to avoid repeating the dev server's host:port in the `ws` / `wss` parameter we pass to the Chrome DevTools frontend. This gives us more flexibility to handle port forwarding and redirects outside of `dev-middleware`. This is mostly useful in Meta's internal VS Code remoting setup, but this particular change should work equally well in open source. Reviewed By: huntie Differential Revision: D54107316
b5c659e to
f86c054
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54107316 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Uses the capability introduced in facebook/react-native-devtools-frontend#4 to avoid repeating the dev server's host:port in the
ws/wssparameter we pass to the Chrome DevTools frontend. This gives us more flexibility to handle port forwarding and redirects outside ofdev-middleware. This is mostly useful in Meta's internal VS Code remoting setup, but this particular change should work equally well in open source.Differential Revision: D54107316