Enable varying feature flags in ReactInstanceIntegrationTest, use modern CDP registry by default#43101
Closed
robhogan wants to merge 2 commits intofacebook:mainfrom
Closed
Enable varying feature flags in ReactInstanceIntegrationTest, use modern CDP registry by default#43101robhogan wants to merge 2 commits intofacebook:mainfrom
robhogan wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
7a27b33 to
8944b98
Compare
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 19, 2024
…ern CDP registry by default (facebook#43101) Summary: Pull Request resolved: facebook#43101 Extends `ReactInstanceIntegrationTest` to allow varying feature flags in tests, using gtest's parameterised tests. Exercise this in `ConsoleLogTest` to test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by Hermes `DecoratedRuntime`. Changelog: [Internal] Differential Revision: D53919148
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 19, 2024
…ern CDP registry by default (facebook#43101) Summary: Pull Request resolved: facebook#43101 Extends `ReactInstanceIntegrationTest` to allow varying feature flags in tests, using gtest's parameterised tests. Exercise this in `ConsoleLogTest` to test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by Hermes `DecoratedRuntime`. Changelog: [Internal] Differential Revision: D53919148
8944b98 to
960fd27
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 19, 2024
…ern CDP registry by default (facebook#43101) Summary: Pull Request resolved: facebook#43101 Extends `ReactInstanceIntegrationTest` to allow varying feature flags in tests, using gtest's parameterised tests. Exercise this in `ConsoleLogTest` to test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by Hermes `DecoratedRuntime`. Changelog: [Internal] Differential Revision: D53919148
960fd27 to
9119d29
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
Summary: Pull Request resolved: facebook#43094 Merge the internal `cxxcdp-tester` project into `jsinspector-modern/tests`. Note: These tests still use RN default feature flags and therefore test against the legacy CDP registry - that's addressed in the next diff. Changelog: [Internal] Differential Revision: D53766994
…ern CDP registry by default (facebook#43101) Summary: Pull Request resolved: facebook#43101 Extends `ReactInstanceIntegrationTest` to allow varying feature flags in tests, using gtest's parameterised tests. Exercise this in `ConsoleLogTest` to test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by Hermes `DecoratedRuntime`. Changelog: [Internal] Differential Revision: D53919148
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53919148 |
9119d29 to
be06cac
Compare
Contributor
|
This pull request has been merged in f0363f5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extends
ReactInstanceIntegrationTestto allow varying feature flags in tests, using gtest's parameterised tests.Exercise this in
ConsoleLogTestto test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by HermesDecoratedRuntime.Changelog: [Internal]
Differential Revision: D53919148