Closed
Conversation
b069237 to
03fe402
Compare
Base commit: 4ecf57e |
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaOnlyArray.java
Outdated
Show resolved
Hide resolved
packages/react-native/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp
Outdated
Show resolved
Hide resolved
packages/react-native/ReactCommon/react/renderer/mapbuffer/tests/MapBufferTest.cpp
Show resolved
Hide resolved
NickGerleman
approved these changes
Feb 17, 2024
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
requested changes
Feb 20, 2024
Contributor
NickGerleman
left a comment
There was a problem hiding this comment.
Left a comment, where someone else noticed the same long to double issue in another file. Was also raised that we should ideally have new tests for each of the structures we are editing, for these scenarios, like the truncation one.
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@NickGerleman I dropped the bridge changes to keep this completely focused on MapBuffer. |
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Feb 22, 2024
Contributor
|
@NickGerleman merged this pull request in 57ed0fb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for 64 bit integer (long) values to MapBuffer. Per the wide gamut color RFC Android encodes wide gamut colors as long values so we need to update MapBuffer to support 64 bit integers as well.
Changelog:
[ANDROID] [ADDED] - Add 64 bit integer (long) value support to MapBuffer
Test Plan:
I've added a test to the MapBuffer test suite. This new API is otherwise currently unused but will be used in subsequent PRs as part of wide gamut color support changes.