Fix FormData to properly handle appended arrays.#32815
Closed
bang9 wants to merge 1 commit intofacebook:mainfrom
Closed
Fix FormData to properly handle appended arrays.#32815bang9 wants to merge 1 commit intofacebook:mainfrom
bang9 wants to merge 1 commit intofacebook:mainfrom
Conversation
Base commit: 725bffc |
Base commit: 725bffc |
Contributor
|
@charlesbdudley has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Hi @charlesbdudley |
Collaborator
|
This pull request was successfully merged by @bang9 in d2e8e7d. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary:
The Array appended to FormData must be transmitted in the form of a string.
However, it is treated as a file object and transmitted, because `typeof Array` is `'object'` too
In network
```js
form.append('array_name', ['a', 'b', 'c'])
// Browser
// Content-Disposition: form-data; name='array_name';
// a,b,c
// ReactNative
// Content-Disposition: form-data; name='array_name';
//
```
## Changelog
[General] [Fixed] - The Array appended to FormData is transmitted as a string
Pull Request resolved: facebook#32815
Test Plan: Added test case
Reviewed By: lunaleaps
Differential Revision: D33369594
Pulled By: charlesbdudley
fbshipit-source-id: 0b5219a2c9f73cf16665dc417cceb4481428ad4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Array appended to FormData must be transmitted in the form of a string.
However, it is treated as a file object and transmitted, because
typeof Arrayis'object'tooIn network
Changelog
[General] [Fixed] - The Array appended to FormData is transmitted as a string
Test Plan
Added test case