Fixing the packager infinite loop on Windows #2789
Conversation
The issue here facebook#2787 The root path '/' dosn't match windows root path
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for the PR! @martinbigio Can you review this please? |
|
Looks good to me! |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/830425153722383/int_phab to review. |
| @@ -226,7 +226,7 @@ class ResolutionRequest { | |||
| realModuleName => { | |||
| const searchQueue = []; | |||
| for (let currDir = path.dirname(fromModule.path); | |||
| currDir !== '/'; | |||
| currDir !== path.parse(fromModule.path).root; | |||
There was a problem hiding this comment.
The result of the path.parse call is constant and this is being evaluated on each iteration so it makes sense to hoist this.
Thanks @sebmck , that make more sence.
|
Thanks @sebmck , yet I think the other code on master causing the ci building failed. |
Summary: The issue here facebook#2787 The root path '/' dosn't match windows root path Closes facebook#2789 Reviewed By: @svcscm Differential Revision: D2452718 Pulled By: @martinbigio
Summary: The issue here facebook/react-native#2787 The root path '/' dosn't match windows root path Closes facebook/react-native#2789 Reviewed By: @svcscm Differential Revision: D2452718 Pulled By: @martinbigio
## Summary: Helps (but doesn't fix) facebook#2789 Replace the custom bash script to pin cmake with an action that upstream React Native is using.
Resolves facebook#2789 ## Summary: Upstream, the Hermes repo changed their default branch from `main` (Legacy Hermes) to `static_h` (HermesV1). Our scripts to look up and build Hermes from source (used on our `main` branch) started pulling in HermesV1 instead of legacy hermes, which we won't support till RN 0.84. Let's fix the lookup logic so always look up the commit from Hermes' `main` branch instead. Let's also update cmake to a version that supports visionOS ## Test Plan: Revert my commit to use JSC on CI so we can see if Hermes passes.
The issue here #2787
The root path '/' dosn't match windows root path