[0.74.0-rc.1] Invariant violation when accessing TurboModules

[tido64]

Old Version

0.73.4

New Version

0.74.0-rc.1

Description

If a New Architecture enabled library implements ReactModuleInfoProvider using a pattern like below:

    override fun getReactModuleInfoProvider(): ReactModuleInfoProvider = ReactModuleInfoProvider {
        val info = ReactModuleInfo(
            WebStorageModule.NAME,
            WebStorageModule::class.java.name,
            false,
            false,
            false,
            false,
            TurboModule::class.java.isAssignableFrom(WebStorageModule::class.java)  // <-- THIS
        )
        mapOf(info.name() to info).toMutableMap()
    }

It will no longer be detected as a TurboModule because TurboModule::class.java.isAssignableFrom() will now return false. The reason is because the TurboModule class used here is no longer the same TurboModule class used for the generated spec: b7191cd

Quite a number of libraries currently use this pattern: https://github.com/search?q=TurboModule.class.isAssignableFrom&type=code

Steps to reproduce

git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version 0.74 -- --core-only
yarn
cd example
yarn android --extra-params "-PnewArchEnabled=true"

# In a separate terminal
yarn start

Affected Platforms

Runtime - Android, Build - MacOS

Output of npx react-native info

n/a

Stacktrace or Logs

n/a

Reproducer

https://github.com/microsoft/react-native-test-app.git

Screenshots and Videos

n/a

[github-actions]

⚠️	Missing Reproducible Example
ℹ️	We could not detect a reproducible example in your issue report. Please provide either: If your bug is UI related: a Snack If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

[tido64]

cc @cortinico

[tido64]

I found that TurboModule::class.java.isAssignableFrom(WebStorageModule::class.java) no longer returns true. I had to hardcode it to true.

It looks like com.facebook.react.turbomodule.core.interfaces.TurboModule is now com.facebook.react.internal.turbomodule.core.interfaces.TurboModule?

Update: Found the change: b7191cd

I copied this from other libraries so I'm pretty sure this will break other people as well.