This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Profiler plug-in for DevTools#1069

Merged

bvaughn merged 138 commits intofacebook:masterfrom

bvaughn:profiler-poc

Aug 15, 2018

Commits on May 24, 2018

Added package script shortcut for testing plain shell
Brian Vaughn
committed

Commits on May 30, 2018

Added record profile button and ooked up to Store/Agent/Hook
Brian Vaughn
committed
ProfilerManager accummulates commit snapsots
Brian Vaughn
committed
ProfilerManager turns profiling on/off for roots
Brian Vaughn
committed
Deeply enable ProfileMode for all roots
Brian Vaughn
committed
Added Profiler plugin/panel
Brian Vaughn
committed

Commits on May 31, 2018

Added some debug logging of commit snapshot
Brian Vaughn
committed
Removed react-addons-create-fragment dependency and usage
Brian Vaughn
committed
Added prop-types package and ran codemod
Brian Vaughn
committed
Upgrade react and react-dom to 16
Brian Vaughn
committed

Commits on Jun 1, 2018

Hackily building a tree with profiling data on commit
Brian Vaughn
committed
Profile contains DevTools internal (string) ID rather than Fiber
Brian Vaughn
committed
Not re-constructing the full tree anymore. Too hacky. Just using the mounted tree.
Brian Vaughn
committed

Commits on Jun 8, 2018

Iterating on the Profiler tab and flame graph. Stashing
Brian Vaughn
committed

Commits on Jun 14, 2018

Iterating on Profiler
Brian Vaughn
committed

Commits on Jun 18, 2018

STASHING
Brian Vaughn
committed
Added react-virtualized-auto-sizer to make graph fill panel height
Brian Vaughn
committed
Color non-rendering nodes differently
Brian Vaughn
committed
Cleaned up flamegraph a little
Brian Vaughn
committed
Removed d3-tip in favor of built-in browser title
Brian Vaughn
committed
Cleaned up cell and graph size variable names
Brian Vaughn
committed
Flamegraph resizes width dynamically
Brian Vaughn
committed
Merge branch 'master' into profiler-poc
Brian Vaughn
committed
Removed package-lock
Brian Vaughn
committed
Fixed duplicate naming conflicts
Brian Vaughn
committed
Reverted changes to plain shell HTML
Brian Vaughn
committed
Reorganized views
Brian Vaughn
committed
Added initial weighted graph, re-organized styles for better sharing
Brian Vaughn
committed

Commits on Jun 19, 2018

Stashing
Brian Vaughn
committed
Flow fixes
Brian Vaughn
committed
Weighted -> Ranked
Brian Vaughn
committed
Click to zoom into Ranked chart
Brian Vaughn
committed
Replaced D3 in RankedSnapshot with SVG
Brian Vaughn
committed
Removed d3 entirely
Brian Vaughn
committed

Commits on Jun 20, 2018

Cleanup CSS and constants shared between graphs
Brian Vaughn
committed
Fixed animated moving
Brian Vaughn
committed
Added icons to commit range buttons
Brian Vaughn
committed
Removed chart CSS; inline styles (with theme compat) replaced
Brian Vaughn
committed
Added initial times-for-fiber view
Brian Vaughn
committed
Double click in fiber-times graph to jump to commit in previously selected graph
Brian Vaughn
committed
Iterating on bar chart
Brian Vaughn
committed
Bugfix and TODO in bar chart
Brian Vaughn
committed
Added hover cursor to chart rects
Brian Vaughn
committed
Disabled commit button styles
Brian Vaughn
committed
Bar chart lables above small nodes
Brian Vaughn
committed
Added 'render N/X' label
Brian Vaughn
committed
Fixed clumping selected/focused node bug
Brian Vaughn
committed

Commits on Jun 21, 2018

Cleaned up comments
Brian Vaughn
committed
Updated react-window to not create so many <svg> tags
Brian Vaughn
committed
Filter native components from ranked view
Brian Vaughn
committed
Iterating on UI
Brian Vaughn
committed

Commits on Jun 22, 2018

STashing
Brian Vaughn
committed
Stashing
Brian Vaughn
committed
Fixed some lint warnings
Brian Vaughn
committed
Virtualized ranked chart
Brian Vaughn
committed
Filter tiny flamegraph nodes that are too small to see/click to render faster
Brian Vaughn
committed

Commits on Jun 25, 2018

Lazily create Snapshot graph data. Add option to filter native nodes.
Brian Vaughn
committed
Cache computed chart data in Profiler store
Brian Vaughn
committed
Improve TTI for flamegraph by reducing the amount of parsed info
Brian Vaughn
committed
Track focused root ID as well
Brian Vaughn
committed

Commits on Jun 26, 2018

Fixed some filtering bugs
Brian Vaughn
committed
Fixed edge-case scaling bug with conditional fibers
Brian Vaughn
committed
Differentiate between mount/update and timing changes
Brian Vaughn
committed
Edge case handling for empty charts
Brian Vaughn
committed
Initial stab at multi-root UI
Brian Vaughn
committed
Flattened data cache structure
Brian Vaughn
committed
Improved no-data check for flamegraph
Brian Vaughn
committed
Force root selection in elements tab before profiling
Brian Vaughn
committed

Commits on Jun 27, 2018

Updated TODO comments; deleted unused file
Brian Vaughn
committed
Comments, mostly
Brian Vaughn
committed
Ranked view supports show/hide native components too
Brian Vaughn
committed

Commits on Jun 28, 2018

Fixed filtering bug in ranked view
Brian Vaughn
committed

Commits on Jul 4, 2018

Upgraded to react-window alpha 4
Brian Vaughn
committed
SVG text shouldn't block rect mouse clicks
Brian Vaughn
committed

Commits on Jul 6, 2018

Renamed *BaseTime to *BaseDuration
Brian Vaughn
committed

Commits on Jul 8, 2018

Changed color scheme to help with red/green color blindness
Brian Vaughn
committed

Commits on Jul 17, 2018

Merge branch 'master' into profiler-poc
Brian Vaughn
committed

Commits on Jul 20, 2018

Changed "No Data..." message
Brian Vaughn
committed

Commits on Jul 22, 2018

Upgraded [email protected]
Brian Vaughn
committed

Commits on Jul 27, 2018

MVP integration with "interactions" based on PR #13253
Brian Vaughn
committed
Renamed RankedSnapshot to SnapshotRanked
Brian Vaughn
committed
Refactored Profiler toolbar UI
Brian Vaughn
committed
Cleaned up UI code a little more
Brian Vaughn
committed
Improved interactions UI; fixed queueing bug in ProfilerStore snapshot processing
Brian Vaughn
committed
Improved interactions UI
Brian Vaughn
committed

Commits on Jul 28, 2018

Improved InteractionTimeline based on feedback
Brian Vaughn
committed
Improved Interaction selected state indicator
Brian Vaughn
committed
Cache interaction data to avoid recomputing
Brian Vaughn
committed
Cleaned up inline styles a bit in the ProfilerTab
Brian Vaughn
committed
Added Interactions detail pane
Brian Vaughn
committed
Removed outdated TODO
Brian Vaughn
committed
Bikeshedding styles
Brian Vaughn
committed
Changed interactions window not to trim by startTime
Brian Vaughn
committed
Offset commit times by start record time
Brian Vaughn
committed
Re-added show-native-nodes toggle
Brian Vaughn
committed
Reset isInspectingSelectedFiber when recording
Brian Vaughn
committed
Fixed "ms" to "s" mislabel
Brian Vaughn
committed

Commits on Jul 29, 2018

Improved Interactions list hover UX slightly
Brian Vaughn
committed

Commits on Jul 30, 2018

Fixed occasional Profiler plugin detection issue
Brian Vaughn
committed
ProfilerTab settings are saved between sessions using chrome.storage.local()
Brian Vaughn
committed
UI tweaks
Brian Vaughn
committed
Add chrome-is-not-undefined check
Brian Vaughn
committed
Fixed interactions-to-snapshot link
Brian Vaughn
committed

Commits on Jul 31, 2018

Added color bounds checking
Brian Vaughn
committed
Fixed interaction start time / display
Brian Vaughn
committed
Edge case guards against null profilerData
Brian Vaughn
committed
Fixex UI bug with interaction bar width
Brian Vaughn
committed
Added CPU % to interaction details pane
Brian Vaughn
committed
Added snapshot/commit details pane
Brian Vaughn
committed
Replaced browser storage API with localStorage
Brian Vaughn
committed
Edge case guards against CPU% bounds
Brian Vaughn
committed
UI tweaks
Brian Vaughn
committed

Commits on Aug 1, 2018

Cleaned up Snapshot duration calculation a bit
Brian Vaughn
committed
JSON serialize localStorage so non-string values also work
Brian Vaughn
committed
Improved UI/UX when inspecting a fiber
Brian Vaughn
committed
Flow fix
Brian Vaughn
committed

Commits on Aug 2, 2018

Merge branch 'master' into profiler-poc
Brian Vaughn
committed
Added up/down key navigation for interactions list
Brian Vaughn
committed

Commits on Aug 3, 2018

Removed some TODO comments that were outdated
Brian Vaughn
committed
Renamed TimeoutComponent -> Placeholder
Brian Vaughn
committed
Nit method rename
Brian Vaughn
committed
Removed unused CSS/style loaders
Brian Vaughn
committed
Reverted some more unnecessary changes
Brian Vaughn
committed
Reverted changes to 'test' folder
Brian Vaughn
committed

Commits on Aug 4, 2018

Profiler works with non-interactions-capable versions of React too
Brian Vaughn
committed

Commits on Aug 6, 2018

Surface render count in Profiler fiber detail pane
Brian Vaughn
committed
Updated to react-window 1.1.1
Brian Vaughn
committed
Replaced HTML slider with windowed bar chart selector
Brian Vaughn
committed

Commits on Aug 7, 2018

Converted Fiber render bar chart to use react-window also
Brian Vaughn
committed

Commits on Aug 8, 2018

Selector snapshot tweaks: click-to-drag and disabled state
Brian Vaughn
committed

Commits on Aug 9, 2018

Selector snapshot tweak: color 0ms durations gray
Brian Vaughn
committed
Lots of little UI tweaks
Brian Vaughn
committed
Added interaction tracking API link. Hide multi-root message for apps with only 1 root.
Brian Vaughn
committed
Added text for show-native-nodes button
Brian Vaughn
committed
Highlight the selected snapshot in the fiber render times pane
Brian Vaughn
committed
Improved no-render-times message
Brian Vaughn
committed

Commits on Aug 14, 2018

Replaced reactjs.org URL with fb.me URL
Brian Vaughn
committed
Organized hook subscriptions in inject for better clarity
Brian Vaughn
committed