Skip to content

refactor(v2): better page preloading#976

Merged
endiliey merged 2 commits into
facebook:masterfrom
endiliey:refactor
Sep 21, 2018
Merged

refactor(v2): better page preloading#976
endiliey merged 2 commits into
facebook:masterfrom
endiliey:refactor

Conversation

@endiliey

@endiliey endiliey commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

Motivation

  • Fix linting precommit
  • Use native react-loadable preloadReady on client
  • Rename prerender to preload since that is what it is actually doing (to avoid bunch of loading screens on first page)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before
capture

After
after

For the website, still works normally

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 21, 2018
@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 3b7e658

https://deploy-preview-976--docusaurus-preview.netlify.com

@endiliey
endiliey merged commit ce5610a into facebook:master Sep 21, 2018
@endiliey
endiliey deleted the refactor branch September 21, 2018 16:42
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* refactor: use native preloadReady for prerender on client

* refactor: rename 'prerender' to 'preload' for correctness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants