Skip to content

docs(website): fix broken external links wrongly modified to use the .mdx extension (ex: github README.mdx)#8509

Merged
slorber merged 2 commits into
facebook:mainfrom
Kesyau:patch-1
Jan 5, 2023
Merged

docs(website): fix broken external links wrongly modified to use the .mdx extension (ex: github README.mdx)#8509
slorber merged 2 commits into
facebook:mainfrom
Kesyau:patch-1

Conversation

@Kesyau

@Kesyau Kesyau commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The links to browserslist's doc are broken.

Test Plan

Preview.

Test links

Deploy preview: https://deploy-preview-8509--docusaurus-2.netlify.app/docs/browser-support#read-more

Related issues/PRs

None.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 5, 2023
@netlify

netlify Bot commented Jan 5, 2023

Copy link
Copy Markdown

[V2]

Name Link
🔨 Latest commit 0df3774
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63b6be124079360008407bec
😎 Deploy Preview https://deploy-preview-8509--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

github-actions Bot commented Jan 5, 2023

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 80 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber

slorber commented Jan 5, 2023

Copy link
Copy Markdown
Collaborator

Thanks, I recently converted all docs to .mdx and was a bit too aggressive when converting markdown links 😅

Will fix the few bad links in this PR

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 5, 2023
@slorber slorber changed the title docs(website): fix broken links to browserslist docs(website): fix broken external links wrongly modified to use the .mdx extension (ex: github README.mdx) Jan 5, 2023
@slorber slorber merged commit 773529a into facebook:main Jan 5, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants