Skip to content

fix(mdx-loader): use React.Fragment as fragment factory - #7392

Merged
Josh-Cena merged 1 commit into
mainfrom
jc/fix-fragment
May 11, 2022
Merged

fix(mdx-loader): use React.Fragment as fragment factory#7392
Josh-Cena merged 1 commit into
mainfrom
jc/fix-fragment

Conversation

@Josh-Cena

@Josh-Cena Josh-Cena commented May 11, 2022

Copy link
Copy Markdown
Collaborator

Pre-flight checklist

Motivation

Regression introduced by #4997

I'm not sure where mdx.Fragment comes from—possibly from MDX v2? But I've simply reverted to the behavior before when we had no pragma.

Test Plan

Test links

Deploy preview: https://deploy-preview-7392--docusaurus-2.netlify.app/tests/pages/markdownPageTests/#details

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 11, 2022
@Josh-Cena
Josh-Cena requested review from lex111 and slorber as code owners May 11, 2022 02:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 11, 2022
@netlify

netlify Bot commented May 11, 2022

Copy link
Copy Markdown

[V2]

Name Link
🔨 Latest commit befa03c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627b225eb187600009a3330a
😎 Deploy Preview https://deploy-preview-7392--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 811 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 615 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena
Josh-Cena merged commit d3788bd into main May 11, 2022
@Josh-Cena
Josh-Cena deleted the jc/fix-fragment branch May 11, 2022 03:02
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing elements wrapped with the short syntax of React.Fragment into a component as its children may cause a page to crash

2 participants