Skip to content

chore(theme-translations): complete German translations#7031

Merged
Josh-Cena merged 4 commits into
facebook:mainfrom
deployn:de-DE
Mar 28, 2022
Merged

chore(theme-translations): complete German translations#7031
Josh-Cena merged 4 commits into
facebook:mainfrom
deployn:de-DE

Conversation

@deployn

@deployn deployn commented Mar 27, 2022

Copy link
Copy Markdown
Contributor

Motivation

Some German locales were still English.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I did only change the locales

Related PRs

@facebook-github-bot

facebook-github-bot commented Mar 27, 2022

Copy link
Copy Markdown
Contributor

Hi @deployn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify

netlify Bot commented Mar 27, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 984b563
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/624162fe5fd5ef0008a85f41
😎 Deploy Preview https://deploy-preview-7031--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

github-actions Bot commented Mar 27, 2022 •
edited
Loading

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7031--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 27, 2022
@facebook-github-bot

facebook-github-bot commented Mar 27, 2022

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena changed the title German translation updated chore(theme-translations): complete German translations Mar 28, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 28, 2022
@Josh-Cena

Josh-Cena commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

Thanks a lot! There are "Read more about {title}" and "{count} items" that need translation as well.

Josh-Cena
Josh-Cena approved these changes Mar 28, 2022
View reviewed changes

@Josh-Cena Josh-Cena left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work!

@Josh-Cena Josh-Cena merged commit 118ca63 into facebook:main Mar 28, 2022
@deployn deployn deleted the de-DE branch March 30, 2022 14:53
@NikolayS NikolayS mentioned this pull request Jul 6, 2023
Open
@Qdigital Qdigital mentioned this pull request Jul 6, 2023
Open
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
@deployn
chore(theme-translations): complete German translations (facebook#7031)
6e9493a 
* Update German locales

* Update German locales

* Update German locales

* update locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes
@slorber slorber Awaiting requested review from slorber slorber is a code owner
@lex111 lex111 Awaiting requested review from lex111

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deployn @facebook-github-bot @Josh-Cena