Skip to content

fix(content-blog): generate feed by reading build output - #6454

Merged
slorber merged 4 commits into
mainfrom
jc/fix-mdx-feed
Jan 26, 2022
Merged

fix(content-blog): generate feed by reading build output#6454
slorber merged 4 commits into
mainfrom
jc/fix-mdx-feed

Conversation

@Josh-Cena

@Josh-Cena Josh-Cena commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

Motivation

Fix #5664
Fix #6195

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The build output now shows all posts' content, including those with MDX.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 23, 2022
Comment thread packages/docusaurus-plugin-content-blog/src/index.ts Outdated
Comment thread packages/docusaurus/src/commands/build.ts
@netlify

netlify Bot commented Jan 23, 2022

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: b789d2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f154f5ff418b00077c78ea

😎 Browse the preview: https://deploy-preview-6454--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Jan 23, 2022

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6454--docusaurus-2.netlify.app/

@github-actions

github-actions Bot commented Jan 23, 2022

Copy link
Copy Markdown

Size Change: +5.27 kB (+1%)

Total Size: 715 kB

Filename Size Change
website/.docusaurus/globalData.json 45.1 kB +1.04 kB (+2%)
website/build/assets/css/styles.********.css 104 kB +682 B (+1%)
website/build/assets/js/main.********.js 536 kB +3.55 kB (+1%)
ℹ️ View Unchanged
Filename Size
website/build/index.html 29.8 kB

compressed-size-action

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 44 kB
website/build/assets/css/styles.********.css 104 kB
website/build/assets/js/main.********.js 532 kB
website/build/index.html 29.8 kB

compressed-size-action

@slorber slorber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks like a nice fix overall, just a few minor changes

I can confirm in Feedly it's working fine, and relative images are not displayed properly 👍

image

Comment thread packages/docusaurus-plugin-content-blog/src/feed.ts Outdated
Comment thread packages/docusaurus-plugin-content-blog/src/feed.ts Outdated
Comment thread packages/docusaurus-plugin-content-blog/src/feed.ts Outdated
Comment thread packages/docusaurus-plugin-content-blog/src/index.ts Outdated
Comment thread packages/docusaurus-theme-classic/src/theme/BlogPostItem/index.tsx Outdated
Comment thread packages/docusaurus/src/commands/build.ts
@Josh-Cena
Josh-Cena requested a review from slorber January 26, 2022 14:37
@slorber

slorber commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

LGTM thanks 👍

@slorber
slorber merged commit 76a8d5f into main Jan 26, 2022
@slorber
slorber deleted the jc/fix-mdx-feed branch January 26, 2022 15:54
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

3 participants