Skip to content

refactor(mdx-loader): use vfile.path to access Markdown file path - #6443

Merged
Josh-Cena merged 1 commit into
mainfrom
jc/use-vfile
Jan 22, 2022
Merged

refactor(mdx-loader): use vfile.path to access Markdown file path#6443
Josh-Cena merged 1 commit into
mainfrom
jc/use-vfile

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

Let's not pass it as options. Prerequisite of #4997. Also wrote some documentation.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Build succeeds.

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 22, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 22, 2022
@netlify

netlify Bot commented Jan 22, 2022

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: aef8c38

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61ec12913249500008bbbfa5

😎 Browse the preview: https://deploy-preview-6443--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6443--docusaurus-2.netlify.app/

@Josh-Cena
Josh-Cena merged commit 3d7ba33 into main Jan 22, 2022
@Josh-Cena
Josh-Cena deleted the jc/use-vfile branch January 22, 2022 14:28
@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 708 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 43.5 kB
website/build/assets/css/styles.********.css 104 kB
website/build/assets/js/main.********.js 531 kB
website/build/index.html 29.6 kB

compressed-size-action

mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants