Skip to content

fix(content-docs): restore behavior when pagination front matter is null#6124

Merged
Josh-Cena merged 2 commits into
mainfrom
jc/fix-pagination
Dec 18, 2021
Merged

fix(content-docs): restore behavior when pagination front matter is null#6124
Josh-Cena merged 2 commits into
mainfrom
jc/fix-pagination

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

Fix #6103

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added one fixture test

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Dec 18, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 18, 2021
@netlify

netlify Bot commented Dec 18, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: a5081e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bd41dcc4488c000736e849

😎 Browse the preview: https://deploy-preview-6124--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Dec 18, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6124--docusaurus-2.netlify.app/

@github-actions

github-actions Bot commented Dec 18, 2021

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 37.8 kB
website/build/assets/css/styles.********.css 101 kB
website/build/assets/js/main.********.js 484 kB
website/build/index.html 29.3 kB

compressed-size-action

@netlify

netlify Bot commented Dec 18, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 165ac7f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bd433576e7e40007443599

😎 Browse the preview: https://deploy-preview-6124--docusaurus-2.netlify.app

@Josh-Cena Josh-Cena merged commit a5d2815 into main Dec 18, 2021
@Josh-Cena Josh-Cena deleted the jc/fix-pagination branch December 18, 2021 02:31
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
…ull (facebook#6124)

* fix(content-docs): restore behavior when pagination front matter is null

* update snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pagination_next / prev no longer working

2 participants