Skip to content

chore: upgrade Prettier + regenerate lock file#5611

Merged
slorber merged 8 commits into
facebook:mainfrom
Josh-Cena:bump-deps
Sep 30, 2021
Merged

chore: upgrade Prettier + regenerate lock file#5611
slorber merged 8 commits into
facebook:mainfrom
Josh-Cena:bump-deps

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

The new version of Prettier has a different formatting approach, also updated a lot of transitive dependencies.

The major reason is because I messed up with the lock file while working on the plugin packing util🤦‍♂️ so to make the diff less confusing for that one, decided to just bump the dependencies :D

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Build & preview

@netlify

netlify Bot commented Sep 25, 2021

Copy link
Copy Markdown

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 95a25b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61543e0a85284200085a7bf8

😎 Browse the preview: https://deploy-preview-5611--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Sep 25, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5611--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 25, 2021
@Josh-Cena

Copy link
Copy Markdown
Collaborator Author

As a sidenote: Prettier recommends to use exact versions (exactly because they introduce lots of git diffs even between minor versions), but seems it's been doing fine up till now

Comment thread packages/docusaurus-theme-bootstrap/src/theme/DebugLayout/index.tsx

@slorber slorber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Not a fan of this large diff though, some changes look good, others a bit weird 🤪

Wonder if it's a good time to do this upgrade

Comment thread website/docs/blog.mdx
Comment thread website/docs/typescript-support.md
@Josh-Cena

Josh-Cena commented Sep 29, 2021

Copy link
Copy Markdown
Collaborator Author

Not a fan of this large diff though, some changes look good, others a bit weird

I mainly just ran Prettier. Any weird & pure style changes are just Prettier to blame🌝

Also there was a breaking NavLink type change with the @types/react-router-dom upgrade, maybe that's the "weird" change you meant? It seems the new react-router-dom has adopted some anti-pattern of accepting a function as className and style so I had to narrow that to the non-function type

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Sep 30, 2021
@slorber

slorber commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

Let's do this to stay up-to-date with Prettier, it's been a while we didn't update it

@slorber slorber merged commit 3f1f825 into facebook:main Sep 30, 2021
@Josh-Cena Josh-Cena deleted the bump-deps branch September 30, 2021 10:54
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* Bump deps

* Run prettier

* Format docs

* Minor refactor

* Collapse objects

* Fix type

* Update lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants