Skip to content

fix(docs): create tags route if only tags exists#5606

Merged
slorber merged 1 commit into
mainfrom
lex111/iss5599
Sep 23, 2021
Merged

fix(docs): create tags route if only tags exists#5606
slorber merged 1 commit into
mainfrom
lex111/iss5599

Conversation

@lex111

@lex111 lex111 commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Motivation

Just fixes #5599.

Have you read the Contributing Guidelines on pull requests?

Resolves

Test Plan

Preview (since we don't use tags, /tags should return 404 error)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Sep 22, 2021
@lex111
lex111 requested a review from slorber as a code owner September 22, 2021 20:13
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 22, 2021
@netlify

netlify Bot commented Sep 22, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 3d77a84

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/614b8e7c6e23c00007c87fdd

😎 Browse the preview: https://deploy-preview-5606--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Sep 22, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5606--docusaurus-2.netlify.app/

@github-actions

github-actions Bot commented Sep 22, 2021

Copy link
Copy Markdown

Size Change: -999 B (0%)

Total Size: 824 kB

Filename Size Change
website/build/assets/js/main.********.js 413 kB -995 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.7 kB 0 B
website/build/assets/css/styles.********.css 94 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38 kB 0 B
website/build/docs/index.html 44.5 kB -2 B (0%)
website/build/docs/installation/index.html 52.7 kB -2 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.3 kB 0 B
website/build/tests/docs/standalone/index.html 22.9 kB 0 B

compressed-size-action

@netlify

netlify Bot commented Sep 22, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: fa17071

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/614b8ffc151d1600083525aa

😎 Browse the preview: https://deploy-preview-5606--docusaurus-2.netlify.app

@slorber

slorber commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

LGTM thanks 👍

@slorber
slorber merged commit e66e045 into main Sep 23, 2021
@slorber
slorber deleted the lex111/iss5599 branch September 23, 2021 11:02
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On build, docusaurus creates a "Tags" page

3 participants