Skip to content

docs: fix more references to Discord channels#5585

Merged
lex111 merged 1 commit into
facebook:mainfrom
Josh-Cena:discord-link
Sep 19, 2021
Merged

docs: fix more references to Discord channels#5585
lex111 merged 1 commit into
facebook:mainfrom
Josh-Cena:discord-link

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

Missed a few places in #5581 because I used case-sensitive global search🤦‍♂️

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 18, 2021
@netlify

netlify Bot commented Sep 18, 2021

Copy link
Copy Markdown

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 6e1b002

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6145855910666a00072b0366

😎 Browse the preview: https://deploy-preview-5585--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 75
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5585--docusaurus-2.netlify.app/

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 19, 2021
@lex111 lex111 merged commit e274c72 into facebook:main Sep 19, 2021
@lex111

lex111 commented Sep 19, 2021

Copy link
Copy Markdown
Contributor

@Josh-Cena thanks!

@Josh-Cena Josh-Cena deleted the discord-link branch September 19, 2021 08:17
@Josh-Cena

Copy link
Copy Markdown
Collaborator Author

The production deployment has been failing for a while I believe, unable to see any new changes to the doc. Can someone inspect that?

@lex111

lex111 commented Sep 19, 2021

Copy link
Copy Markdown
Contributor

Apparently this is due to the zh-CN translation.

image

@Josh-Cena

Copy link
Copy Markdown
Collaborator Author

Fixed that. Maybe we should set onBrokenLinks: 'warn' in production so that translation contributors don't crash the entire site?

@lex111

lex111 commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

I think @slorber will clarify this point.

@slorber

slorber commented Sep 21, 2021

Copy link
Copy Markdown
Collaborator

I'd prefer to keep throwing until we have a way to report broken link errors, otherwise those could stay unnoticed (I don't think we often check for logs of successful deployments)

We could extend the system to accept a function to have CI build warnings being sent to a Discord channel or something

@Josh-Cena

Copy link
Copy Markdown
Collaborator Author

Is it possible to report production build status in the CI status? I have a project that uses Netlify and deployment is part of CI, so I can know if it fails through GitHub

@slorber

slorber commented Sep 21, 2021

Copy link
Copy Markdown
Collaborator

We have an icon on the repo readme:

image

This is not visible enough though.

Netlify has a notification system, but afaik it reports ALL failures, not just for the production branch, and it's a bit annoying. Also no Discord integration.

Netlify does not provide commit statuses for the production branch, only deploy previews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants