fix(v2): align installed core-js version with babel config#4366
Merged
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 2d39af7 https://app.netlify.com/sites/docusaurus-1/deploys/6046f9ef0d0d360007502f95 |
Contributor
Author
|
netlify failed due to some unrelated issue: |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 2d39af7 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4366--docusaurus-2.netlify.app/classic/ |
Collaborator
|
thanks, make sense |
mrizwanashiq
pushed a commit
to mrizwanashiq/docusaurus
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove dead or unnecessary dependencies, currently for unknown reason docosaurus requires core-js@2 and babel is configured to use core-js@3, this was not a big issue for end customer as core-js@3 is installed as dependency of dependency, but its still an issue
docusaurus/packages/docusaurus/src/babel/preset.ts
Lines 30 to 32 in 9a6d6a9
Have you read the Contributing Guidelines on pull requests?
yes
Related PRs
#3055