Skip to content

fix(v2): align installed core-js version with babel config#4366

Merged
slorber merged 1 commit into
facebook:masterfrom
armano2:fix/core-js
Mar 9, 2021
Merged

fix(v2): align installed core-js version with babel config#4366
slorber merged 1 commit into
facebook:masterfrom
armano2:fix/core-js

Conversation

@armano2

@armano2 armano2 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

Motivation

Remove dead or unnecessary dependencies, currently for unknown reason docosaurus requires core-js@2 and babel is configured to use core-js@3, this was not a big issue for end customer as core-js@3 is installed as dependency of dependency, but its still an issue

useBuiltIns: 'entry',
loose: true,
corejs: '3',

Have you read the Contributing Guidelines on pull requests?

yes

Related PRs

#3055

@armano2 armano2 requested review from lex111 and slorber as code owners March 9, 2021 04:30
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 9, 2021
@netlify

netlify Bot commented Mar 9, 2021

Copy link
Copy Markdown

@armano2

armano2 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

netlify failed due to some unrelated issue:

5:33:16 AM: $ cd .. && crowdin download -b master --config crowdin-v1.yml
5:33:16 AM: ❌ Configuration file is invalid. Check the following parameters in your configuration file:
5:33:16 AM: 	- Required option 'api_token' is missing in the configuration file

@netlify

netlify Bot commented Mar 9, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 2d39af7

https://deploy-preview-4366--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Mar 9, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4366--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 9, 2021
@slorber slorber changed the title fix: align installed core-js version with babel config fix(v2): align installed core-js version with babel config Mar 9, 2021
@slorber

slorber commented Mar 9, 2021

Copy link
Copy Markdown
Collaborator

thanks, make sense

@slorber slorber merged commit 25489b4 into facebook:master Mar 9, 2021
@armano2 armano2 deleted the fix/core-js branch March 9, 2021 12:10
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 9, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants