Skip to content

docs(v2): Do not encourage using the permalink prop#4112

Merged
slorber merged 1 commit into
masterfrom
slorber-patch-3-1
Jan 28, 2021
Merged

docs(v2): Do not encourage using the permalink prop#4112
slorber merged 1 commit into
masterfrom
slorber-patch-3-1

Conversation

@slorber

@slorber slorber commented Jan 28, 2021

Copy link
Copy Markdown
Collaborator

Motivation

It's better to not use the permalink props on theme Layout component.

We compute a canonical URL by default already, so it's not needed.

Related to #4109

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 28, 2021
@slorber slorber requested a review from lex111 as a code owner January 28, 2021 09:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 28, 2021
@netlify

netlify Bot commented Jan 28, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit dc736b2

https://deploy-preview-4112--docusaurus-1.netlify.app

@netlify

netlify Bot commented Jan 28, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit dc736b2

https://deploy-preview-4112--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

Size Change: +1 B (0%)

Total Size: 28.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.8 kB +1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.87 kB 0 B

compressed-size-action

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4112--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 671748f into master Jan 28, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber-patch-3-1 branch August 17, 2021 17:50
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants