Skip to content

refactor(v2): improve regex matching code-block title#3685

Merged
slorber merged 1 commit into
facebook:masterfrom
hong4rc:patch-2
Nov 5, 2020
Merged

refactor(v2): improve regex matching code-block title#3685
slorber merged 1 commit into
facebook:masterfrom
hong4rc:patch-2

Conversation

@hong4rc

@hong4rc hong4rc commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

Motivation

#3671 can't work with Safari, this PR to fix it(still quickly+sort code)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested with Safari
image

Related PRs

#3671

@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 8159621

https://deploy-preview-3685--docusaurus-2.netlify.app

@lex111 lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good this time.

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 5, 2020
@slorber slorber merged commit f8a6b39 into facebook:master Nov 5, 2020
@hong4rc hong4rc deleted the patch-2 branch November 5, 2020 12:08
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants