feat(v2): persist docs preferred version#3543
Merged
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit d9c4d9b |
Collaborator
Author
|
TODO before merge:
|
Collaborator
Author
slorber
commented
Oct 9, 2020
| import {useDocsData} from '@theme/hooks/useDocs'; | ||
|
|
||
| // TODO why this import does not work! | ||
| // import {DEFAULT_PLUGIN_ID} from '@docusaurus/constants'; |
Collaborator
Author
There was a problem hiding this comment.
no idea why, but unable to make this work
…redVersion ?? latestVersion
Merged
3 tasks
mrizwanashiq
pushed a commit
to mrizwanashiq/docusaurus
that referenced
this pull request
Jun 25, 2026
* persist docs preferred version * add proper implementation for useDocsPreferredVersion * add proper implementation for useDocsPreferredVersion * useDocsPreferredVersion => make localstorage read only after mount * why @docusaurus/constants can't work? * fix weird TS issue when not duplicating constants * add basic @docusaurus/constants doc * attempt to fix docs-only mode where we should not call useDocs hooks * attempt to fix docs-only mode where we should not call useDocs hooks * fix children * encapsulate hacky isDocsPluginEnabled in docsUtils * use same priority order for all navbar items: activeVersion ?? preferredVersion ?? latestVersion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Problem:
The versions dropdown is reset to latest version (currently
2.0.0-alpha.66 (unreleased)).If the user choose to use a specific version, we can persist in local storage that choice so that the dropdown version does not "jump" from one version to the other.
We shouldn't treat the stored value as "safe" because it can be stale and return outdated versionName that is not part of the site anymore, so it's a best effort only.
Asked by @Simek as a possible enhancement to RN website.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
preview