Update eslint-plugin-jsx-a11y version#5330
Merged
Timer merged 1 commit intofacebook:masterfrom Oct 6, 2018
Merged
Conversation
Contributor
Author
|
Ok, I came back later and saw that the Travis build had failed. I tried to run tests locally but, as indicated in the docs, this take a bit more effort on Windows. Locally my tests then seem to fail on some snapshot test error. I think this totally unrelated and has something to do with my enviroment. Will need to check this out, but I'm out of time for the weekend. Unless someone can check if this is related to upgrading the one package or something else. Or if someone can point me in the right direction as to why this is failing. I see the following but not the reason why it failed: |
|
test is sometimes flaky, try retriggering the CI by adding a few no-ops (like a blank line). |
Contributor
|
Thanks! |
Closed
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Oct 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the version of
eslint-plugin-jsx-a11yfrom6.1.1to6.1.2.Properly closes #4141
Adds clearer error messages for the
anchor-is-validrule as per https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/486.