Detect current directory [A-Z]*file, eg. Makefile#173
Merged
pcottle merged 1 commit intofacebook:masterfrom Jul 24, 2015
Merged
Detect current directory [A-Z]*file, eg. Makefile#173pcottle merged 1 commit intofacebook:masterfrom
pcottle merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Whoops sorry I missed this @Shenil ! I agree its already been discussed a bunch but since this PR has test coverage and covers a pretty valid usecase (files often in the root directories), I'm more than happy to merge it. Thanks for contributing! |
pcottle
added a commit
that referenced
this pull request
Jul 24, 2015
Detect current directory [A-Z]*file, eg. Makefile
Contributor
Author
|
Anytime. Glad to see it get merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that matching files without extensions in the current directory has already been discussed at length before, such as in #83 and #55.
Feel free to close if this is too narrow a use-case, but I find matching for current directory [A-Z]*files, a la Podfile, Gemfile, Makefile, etc. to be a useful addition because these files often appear in the root directories for projects, and would not create too many false positives.