Method to consolidate Experiment.status from generator runs#4900
Closed
CristianLara wants to merge 3 commits intofacebook:mainfrom
Closed
Method to consolidate Experiment.status from generator runs#4900CristianLara wants to merge 3 commits intofacebook:mainfrom
CristianLara wants to merge 3 commits intofacebook:mainfrom
Conversation
|
@CristianLara has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92985915. |
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 11, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Differential Revision: D92985915
1c0766d to
89fba1c
Compare
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 11, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Differential Revision: D92985915
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 11, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Differential Revision: D92985915
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4900 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 595 595
Lines 62841 62928 +87
=======================================
+ Hits 60826 60912 +86
- Misses 2015 2016 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 13, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Reviewed By: lena-kashtelyan Differential Revision: D92985915
89fba1c to
c502f09
Compare
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 13, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Reviewed By: lena-kashtelyan Differential Revision: D92985915
CristianLara
added a commit
to CristianLara/Ax
that referenced
this pull request
Feb 13, 2026
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Reviewed By: lena-kashtelyan Differential Revision: D92985915
Summary: ## Summary Add `suggested_experiment_status` column to `GeneratorRun`. Some benefits: 1. We don't need to modify the GS.gen() or Orchestrator methods to pass along a suggested status via tuple, instead it's baked into the GeneratorRuns that are already being passed along 2. The suggested status are more clearly stored in the database for historical tracking Prior to this approach I tried changing `GS.gen()` to return a tuple including the `suggested_experiment_status` but that over-complicated callsites. ## AOSC DIFF D92476170 Reviewed By: lena-kashtelyan Differential Revision: D88091530
…rRun (facebook#4885) Summary: In the previous diff (D88091530) we added `suggested_experiment_status` the column to GeneratorRun, now we populate it during creation from GenerationNode. Reviewed By: lena-kashtelyan Differential Revision: D92555215
…#4900) Summary: Add a new static method `experiment_status_from_generator_runs()` to `GenerationStrategy` that extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and: - Returns None with a warning if there are conflicting statuses across runs - Returns None with an info log if no statuses are found - Returns the single agreed-upon status otherwise Reviewed By: lena-kashtelyan Differential Revision: D92985915
c502f09 to
00c300f
Compare
|
This pull request has been merged in 8341a87. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new static method
experiment_status_from_generator_runs()toGenerationStrategythat extracts and validates a suggested ExperimentStatus from a list of GeneratorRun objects. It collects all unique suggested_experiment_status values from the runs and:Differential Revision: D92985915