when read rich or phonetic with EOF,then read it at next continue#45
Open
gr258 wants to merge 1 commit intoextrame:masterfrom
Open
when read rich or phonetic with EOF,then read it at next continue#45gr258 wants to merge 1 commit intoextrame:masterfrom
gr258 wants to merge 1 commit intoextrame:masterfrom
Conversation
Owner
|
I dont't think this patch is acceptable, you can add your change but you can't remove the other feature like removing ver5 support and others make sure just add something and don't affect others. |
Author
|
I dont't know the meaning of "removing ver5 support".In the first "else" branch, the w.Is5ver is false, so the next "if w.Is5ver " is a dead code,that's why i remove this condition. code: |
sergeilem
reviewed
Dec 6, 2018
| } | ||
| for err == nil && offset_pre < len(wb.sst) { | ||
| var str string | ||
| if size > 0 { |
Contributor
There was a problem hiding this comment.
God, t thought i am the first person who found a bug here. Same patch in my PR #50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In get_string function,when read rich or phonetic with EOF,the w.continue_rich and w.continue_apsb are not correct,it shout sub read count,then read the left count at next continue stream.